Lint: Migrate linter config, use local linter, fix issues

Signed-off-by: Knut Ahlers <knut@ahlers.me>
2025-04-06 13:10:15 +02:00 · 2025-04-06 13:10:15 +02:00 · 2393b2c4ab
commit 2393b2c4ab
parent a6b30aa6e7
10 changed files with 173 additions and 1331 deletions
--- a/.golangci.yml
+++ b/.golangci.yml
@ -1,174 +1,146 @@
-# Derived from https://github.com/golangci/golangci-lint/blob/master/.golangci.example.yml
-
---
+version: '2'

 run:
-  # timeout for analysis, e.g. 30s, 5m, default is 1m
-  timeout: 5m
-  # Force readonly modules usage for checking
  modules-download-mode: readonly

 output:
  formats:
-    - format: tab
+    tab:
      path: stdout
+      colors: false
+
+linters:
+  default: none
+  enable:
+    - asciicheck
+    - bidichk
+    - bodyclose
+    - containedctx
+    - contextcheck
+    - copyloopvar
+    - dogsled
+    - durationcheck
+    - errcheck
+    - errchkjson
+    - forbidigo
+    - funlen
+    - gocognit
+    - goconst
+    - gocritic
+    - gocyclo
+    - godox
+    - gosec
+    - govet
+    - ineffassign
+    - misspell
+    - mnd
+    - nakedret
+    - nilerr
+    - nilnil
+    - noctx
+    - nolintlint
+    - revive
+    - staticcheck
+    - unconvert
+    - unused
+    - wastedassign
+    - wrapcheck
+
+  settings:
+    funlen:
+      lines: 100
+      statements: 60
+
+    gocyclo:
+      min-complexity: 15
+
+    mnd:
+      ignored-functions:
+        - strconv.(?:Format|Parse)\B+
+
+    revive:
+      rules:
+        - name: atomic
+        - name: banned-characters
+          arguments:
+            - ;
+        - name: bare-return
+        - name: blank-imports
+        - name: bool-literal-in-expr
+        - name: call-to-gc
+        - name: confusing-naming
+        - name: confusing-results
+        - name: constant-logical-expr
+        - name: context-as-argument
+        - name: context-keys-type
+        - name: deep-exit
+        - name: defer
+        - name: dot-imports
+        - name: duplicated-imports
+        - name: early-return
+        - name: empty-block
+        - name: empty-lines
+        - name: errorf
+        - name: error-naming
+        - name: error-return
+        - name: error-strings
+        - name: exported
+          arguments:
+            - sayRepetitiveInsteadOfStutters
+        - name: flag-parameter
+        - name: get-return
+        - name: identical-branches
+        - name: if-return
+        - name: import-shadowing
+        - name: increment-decrement
+        - name: indent-error-flow
+        - name: modifies-parameter
+        - name: modifies-value-receiver
+        - name: optimize-operands-order
+        - name: range
+        - name: range-val-address
+        - name: range-val-in-closure
+        - name: receiver-naming
+        - name: redefines-builtin-id
+        - name: string-of-int
+        - name: struct-tag
+        - name: superfluous-else
+        - name: time-equal
+        - name: time-naming
+        - name: unconditional-recursion
+        - name: unexported-naming
+        - name: unexported-return
+        - name: unhandled-error
+          arguments:
+            - fmt.(Fp|P)rint(f|ln|)
+        - name: unnecessary-stmt
+        - name: unreachable-code
+        - name: unused-parameter
+        - name: unused-receiver
+        - name: useless-break
+        - name: var-declaration
+        - name: var-naming
+        - name: waitgroup-by-value
+
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

 issues:
-  # This disables the included exclude-list in golangci-lint as that
-  # list for example fully hides G304 gosec rule, errcheck, exported
-  # rule of revive and other errors one really wants to see.
-  # Smme detail: https://github.com/golangci/golangci-lint/issues/456
-  exclude-use-default: false
-  # Don't limit the number of shown issues: Report ALL of them
  max-issues-per-linter: 0
  max-same-issues: 0

-linters:
-  disable-all: true
+formatters:
  enable:
-    - asciicheck    # Simple linter to check that your code does not contain non-ASCII identifiers [fast: true, auto-fix: false]
-    - bidichk       # Checks for dangerous unicode character sequences [fast: true, auto-fix: false]
-    - bodyclose     # checks whether HTTP response body is closed successfully [fast: true, auto-fix: false]
-    - containedctx  # containedctx is a linter that detects struct contained context.Context field [fast: true, auto-fix: false]
-    - contextcheck  # check the function whether use a non-inherited context [fast: false, auto-fix: false]
-    - copyloopvar   # copyloopvar is a linter detects places where loop variables are copied [fast: true, auto-fix: false]
-    - dogsled       # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f()) [fast: true, auto-fix: false]
-    - durationcheck # check for two durations multiplied together [fast: false, auto-fix: false]
-    - errcheck      # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases [fast: false, auto-fix: false]
-    - errchkjson    # Checks types passed to the json encoding functions. Reports unsupported types and optionally reports occations, where the check for the returned error can be omitted. [fast: false, auto-fix: false]
-    - forbidigo     # Forbids identifiers [fast: true, auto-fix: false]
-    - funlen        # Tool for detection of long functions [fast: true, auto-fix: false]
-    - gocognit      # Computes and checks the cognitive complexity of functions [fast: true, auto-fix: false]
-    - goconst       # Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
-    - gocritic      # The most opinionated Go source code linter [fast: true, auto-fix: false]
-    - gocyclo       # Computes and checks the cyclomatic complexity of functions [fast: true, auto-fix: false]
-    - godox         # Tool for detection of FIXME, TODO and other comment keywords [fast: true, auto-fix: false]
-    - gofmt         # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification [fast: true, auto-fix: true]
-    - gofumpt       # Gofumpt checks whether code was gofumpt-ed. [fast: true, auto-fix: true]
-    - goimports     # Goimports does everything that gofmt does. Additionally it checks unused imports [fast: true, auto-fix: true]
-    - gosec         # Inspects source code for security problems [fast: true, auto-fix: false]
-    - gosimple      # Linter for Go source code that specializes in simplifying a code [fast: true, auto-fix: false]
-    - govet         # Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: true, auto-fix: false]
-    - ineffassign   # Detects when assignments to existing variables are not used [fast: true, auto-fix: false]
-    - misspell      # Finds commonly misspelled English words in comments [fast: true, auto-fix: true]
-    - mnd           # An analyzer to detect magic numbers. [fast: true, auto-fix: false]
-    - nakedret      # Finds naked returns in functions greater than a specified function length [fast: true, auto-fix: false]
-    - nilerr        # Finds the code that returns nil even if it checks that the error is not nil. [fast: false, auto-fix: false]
-    - nilnil        # Checks that there is no simultaneous return of `nil` error and an invalid value. [fast: false, auto-fix: false]
-    - noctx         # noctx finds sending http request without context.Context [fast: true, auto-fix: false]
-    - nolintlint    # Reports ill-formed or insufficient nolint directives [fast: true, auto-fix: false]
-    - revive        # Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint. [fast: false, auto-fix: false]
-    - staticcheck   # Staticcheck is a go vet on steroids, applying a ton of static analysis checks [fast: true, auto-fix: false]
-    - stylecheck    # Stylecheck is a replacement for golint [fast: true, auto-fix: false]
-    - tenv          # tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17 [fast: false, auto-fix: false]
-    - typecheck     # Like the front-end of a Go compiler, parses and type-checks Go code [fast: true, auto-fix: false]
-    - unconvert     # Remove unnecessary type conversions [fast: true, auto-fix: false]
-    - unused        # Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false]
-    - wastedassign  # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false]
-    - wrapcheck     # Checks that errors returned from external packages are wrapped [fast: false, auto-fix: false]
-
-linters-settings:
-  funlen:
-    lines: 100
-    statements: 60
-
-  gocyclo:
-    # minimal code complexity to report, 30 by default (but we recommend 10-20)
-    min-complexity: 15
-
-  gomnd:
-    ignored-functions: 'strconv.(?:Format|Parse)\B+'
-
-  revive:
-    rules:
-      #- name: add-constant           # Suggests using constant for magic numbers and string literals
-                                      # Opinion: Makes sense for strings, not for numbers but checks numbers
-      #- name: argument-limit         # Specifies the maximum number of arguments a function can receive | Opinion: Don't need this
-      - name: atomic                  # Check for common mistaken usages of the `sync/atomic` package
-      - name: banned-characters       # Checks banned characters in identifiers
-        arguments:
-          - ';' # Greek question mark
-      - name: bare-return             # Warns on bare returns
-      - name: blank-imports           # Disallows blank imports
-      - name: bool-literal-in-expr    # Suggests removing Boolean literals from logic expressions
-      - name: call-to-gc              # Warns on explicit call to the garbage collector
-      #- name: cognitive-complexity   # Sets restriction for maximum Cognitive complexity.
-                                      # There is a dedicated linter for this
-      - name: confusing-naming        # Warns on methods with names that differ only by capitalization
-      - name: confusing-results       # Suggests to name potentially confusing function results
-      - name: constant-logical-expr   # Warns on constant logical expressions
-      - name: context-as-argument     # `context.Context` should be the first argument of a function.
-      - name: context-keys-type       # Disallows the usage of basic types in `context.WithValue`.
-      #- name: cyclomatic             # Sets restriction for maximum Cyclomatic complexity.
-                                      # There is a dedicated linter for this
-      #- name: datarace               # Spots potential dataraces
-                                      # Is not (yet) available?
-      - name: deep-exit               # Looks for program exits in funcs other than `main()` or `init()`
-      - name: defer                   # Warns on some [defer gotchas](https://blog.learngoprogramming.com/5-gotchas-of-defer-in-go-golang-part-iii-36a1ab3d6ef1)
-      - name: dot-imports             # Forbids `.` imports.
-      - name: duplicated-imports      # Looks for packages that are imported two or more times
-      - name: early-return            # Spots if-then-else statements that can be refactored to simplify code reading
-      - name: empty-block             # Warns on empty code blocks
-      - name: empty-lines             # Warns when there are heading or trailing newlines in a block
-      - name: errorf                  # Should replace `errors.New(fmt.Sprintf())` with `fmt.Errorf()`
-      - name: error-naming            # Naming of error variables.
-      - name: error-return            # The error return parameter should be last.
-      - name: error-strings           # Conventions around error strings.
-      - name: exported                # Naming and commenting conventions on exported symbols.
-        arguments: ['sayRepetitiveInsteadOfStutters']
-      #- name: file-header            # Header which each file should have.
-                                      # Useless without config, have no config for it
-      - name: flag-parameter          # Warns on boolean parameters that create a control coupling
-      #- name: function-length        # Warns on functions exceeding the statements or lines max
-                                      # There is a dedicated linter for this
-      #- name: function-result-limit  # Specifies the maximum number of results a function can return
-                                      # Opinion: Don't need this
-      - name: get-return              # Warns on getters that do not yield any result
-      - name: identical-branches      # Spots if-then-else statements with identical `then` and `else` branches
-      - name: if-return               # Redundant if when returning an error.
-      #- name: imports-blacklist      # Disallows importing the specified packages
-                                      # Useless without config, have no config for it
-      - name: import-shadowing        # Spots identifiers that shadow an import
-      - name: increment-decrement     # Use `i++` and `i--` instead of `i += 1` and `i -= 1`.
-      - name: indent-error-flow       # Prevents redundant else statements.
-      #- name: line-length-limit      # Specifies the maximum number of characters in a lined
-                                      # There is a dedicated linter for this
-      #- name: max-public-structs     # The maximum number of public structs in a file.
-                                      # Opinion: Don't need this
-      - name: modifies-parameter      # Warns on assignments to function parameters
-      - name: modifies-value-receiver # Warns on assignments to value-passed method receivers
-      #- name: nested-structs         # Warns on structs within structs
-                                      # Opinion: Don't need this
-      - name: optimize-operands-order # Checks inefficient conditional expressions
-      #- name: package-comments       # Package commenting conventions.
-                                      # Opinion: Don't need this
-      - name: range                   # Prevents redundant variables when iterating over a collection.
-      - name: range-val-address       # Warns if address of range value is used dangerously
-      - name: range-val-in-closure    # Warns if range value is used in a closure dispatched as goroutine
-      - name: receiver-naming         # Conventions around the naming of receivers.
-      - name: redefines-builtin-id    # Warns on redefinitions of builtin identifiers
-      #- name: string-format          # Warns on specific string literals that fail one or more user-configured regular expressions
-                                      # Useless without config, have no config for it
-      - name: string-of-int           # Warns on suspicious casts from int to string
-      - name: struct-tag              # Checks common struct tags like `json`,`xml`,`yaml`
-      - name: superfluous-else        # Prevents redundant else statements (extends indent-error-flow)
-      - name: time-equal              # Suggests to use `time.Time.Equal` instead of `==` and `!=` for equality check time.
-      - name: time-naming             # Conventions around the naming of time variables.
-      - name: unconditional-recursion # Warns on function calls that will lead to (direct) infinite recursion
-      - name: unexported-naming       # Warns on wrongly named un-exported symbols
-      - name: unexported-return       # Warns when a public return is from unexported type.
-      - name: unhandled-error         # Warns on unhandled errors returned by funcion calls
-        arguments:
-          - "fmt.(Fp|P)rint(f|ln|)"
-      - name: unnecessary-stmt        # Suggests removing or simplifying unnecessary statements
-      - name: unreachable-code        # Warns on unreachable code
-      - name: unused-parameter        # Suggests to rename or remove unused function parameters
-      - name: unused-receiver         # Suggests to rename or remove unused method receivers
-      #- name: use-any                # Proposes to replace `interface{}` with its alias `any`
-                                      # Is not (yet) available?
-      - name: useless-break           # Warns on useless `break` statements in case clauses
-      - name: var-declaration         # Reduces redundancies around variable declaration.
-      - name: var-naming              # Naming rules.
-      - name: waitgroup-by-value      # Warns on functions taking sync.WaitGroup as a by-value parameter
-
-...
+    - gofmt
+    - gofumpt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
--- a/2
+++ b/2
@ -4,7 +4,7 @@ HUGO_VERSION:=0.117.0
 ## Tool Binaries
 GO_RUN := go run -modfile ./tools/go.mod
 GO_TEST = $(GO_RUN) gotest.tools/gotestsum --format pkgname
-GOLANCI_LINT = $(GO_RUN) github.com/golangci/golangci-lint/cmd/golangci-lint
+GOLANCI_LINT = golangci-lint

 ##@ General

--- a/config.go
+++ b/config.go
@ -216,7 +216,7 @@ func writeConfigToYAML(filename, authorName, authorEmail, summary string, obj *c
 	}

 	if err = yaml.NewEncoder(tmpFile).Encode(obj); err != nil {
-		tmpFile.Close() //nolint:errcheck,gosec,revive
+		tmpFile.Close() //nolint:errcheck,gosec
 		return errors.Wrap(err, "encoding config")
 	}

--- a/internal/actors/quotedb/database.go
+++ b/internal/actors/quotedb/database.go
@ -85,11 +85,11 @@ func getQuote(db database.Connector, channel string, quote int) (int, string, er

 func getQuoteRaw(db database.Connector, channel string, quoteIdx int) (int, int64, string, error) {
 	if quoteIdx == 0 {
-		max, err := getMaxQuoteIdx(db, channel)
+		maxQuoteIdx, err := getMaxQuoteIdx(db, channel)
 		if err != nil {
 			return 0, 0, "", errors.Wrap(err, "getting max quote idx")
 		}
-		quoteIdx = rand.Intn(max) + 1 // #nosec G404 // no need for cryptographic safety
+		quoteIdx = rand.Intn(maxQuoteIdx) + 1 // #nosec G404 // no need for cryptographic safety
 	}

 	var q quote
--- a/internal/actors/quotedb/http.go
+++ b/internal/actors/quotedb/http.go
@ -181,7 +181,7 @@ func handleDeleteQuote(w http.ResponseWriter, r *http.Request) {
 func handleListQuotes(w http.ResponseWriter, r *http.Request) {
 	if strings.HasPrefix(r.Header.Get("Accept"), "text/html") {
 		w.Header().Set("Content-Type", "text/html")
-		w.Write(listFrontend) //nolint:errcheck,gosec,revive
+		w.Write(listFrontend) //nolint:errcheck,gosec
 		return
 	}

@ -218,7 +218,7 @@ func handleReplaceQuotes(w http.ResponseWriter, r *http.Request) {

 func handleScript(w http.ResponseWriter, _ *http.Request) {
 	w.Header().Set("Content-Type", "text/javascript")
-	w.Write(listScript) //nolint:errcheck,gosec,revive
+	w.Write(listScript) //nolint:errcheck,gosec
 }

 func handleUpdateQuote(w http.ResponseWriter, r *http.Request) {
--- a/internal/linkcheck/resolver.go
+++ b/internal/linkcheck/resolver.go
@ -83,7 +83,7 @@ func (resolver) getJar() *cookiejar.Jar {
 // resolveFinal takes a link and looks up the final destination of
 // that link after all redirects were followed
 //
-//nolint:funlen,gocyclo
+//nolint:gocyclo
 func (r resolver) resolveFinal(link string, cookieJar *cookiejar.Jar, callStack *stack) string {
 	if !linkTest.MatchString(link) && !r.skipValidation {
 		return ""
--- a/internal/template/date/interval_test.go
+++ b/internal/template/date/interval_test.go
@ -13,7 +13,6 @@ import (
 //go:embed tzdata
 var tzDataEuropeBerlin []byte

-//nolint:funlen // This is just a collection of test cases
 func TestNewInterval(t *testing.T) {
 	tz, err := time.LoadLocationFromTZData("Europe/Berlin", tzDataEuropeBerlin)
 	require.NoError(t, err)
--- a/tools/go.mod
+++ b/tools/go.mod
@ -3,192 +3,23 @@ module tools
 go 1.23.1

 require (
-	github.com/golangci/golangci-lint v1.61.0
-	gotest.tools/gotestsum v1.12.0
+	gotest.tools/gotestsum v1.12.1
 	mvdan.cc/gofumpt v0.7.0
 )

 require (
-	4d63.com/gocheckcompilerdirectives v1.2.1 // indirect
-	4d63.com/gochecknoglobals v0.2.1 // indirect
-	github.com/4meepo/tagalign v1.3.4 // indirect
-	github.com/Abirdcfly/dupword v0.1.1 // indirect
-	github.com/Antonboom/errname v0.1.13 // indirect
-	github.com/Antonboom/nilnil v0.1.9 // indirect
-	github.com/Antonboom/testifylint v1.4.3 // indirect
-	github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c // indirect
-	github.com/Crocmagnon/fatcontext v0.5.2 // indirect
-	github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24 // indirect
-	github.com/GaijinEntertainment/go-exhaustruct/v3 v3.3.0 // indirect
-	github.com/Masterminds/semver/v3 v3.3.0 // indirect
-	github.com/OpenPeeDeeP/depguard/v2 v2.2.0 // indirect
-	github.com/alecthomas/go-check-sumtype v0.1.4 // indirect
-	github.com/alexkohler/nakedret/v2 v2.0.4 // indirect
-	github.com/alexkohler/prealloc v1.0.0 // indirect
-	github.com/alingse/asasalint v0.0.11 // indirect
-	github.com/ashanbrown/forbidigo v1.6.0 // indirect
-	github.com/ashanbrown/makezero v1.1.1 // indirect
-	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/bitfield/gotestdox v0.2.2 // indirect
-	github.com/bkielbasa/cyclop v1.2.1 // indirect
-	github.com/blizzy78/varnamelen v0.8.0 // indirect
-	github.com/bombsimon/wsl/v4 v4.4.1 // indirect
-	github.com/breml/bidichk v0.2.7 // indirect
-	github.com/breml/errchkjson v0.3.6 // indirect
-	github.com/butuzov/ireturn v0.3.0 // indirect
-	github.com/butuzov/mirror v1.2.0 // indirect
-	github.com/catenacyber/perfsprint v0.7.1 // indirect
-	github.com/ccojocar/zxcvbn-go v1.0.2 // indirect
-	github.com/cespare/xxhash/v2 v2.1.2 // indirect
-	github.com/charithe/durationcheck v0.0.10 // indirect
-	github.com/chavacava/garif v0.1.0 // indirect
-	github.com/ckaznocha/intrange v0.2.0 // indirect
-	github.com/curioswitch/go-reassign v0.2.0 // indirect
-	github.com/daixiang0/gci v0.13.5 // indirect
-	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/denis-tingaikin/go-header v0.5.0 // indirect
 	github.com/dnephin/pflag v1.0.7 // indirect
-	github.com/ettle/strcase v0.2.0 // indirect
-	github.com/fatih/color v1.17.0 // indirect
-	github.com/fatih/structtag v1.2.0 // indirect
-	github.com/firefart/nonamedreturns v1.0.5 // indirect
-	github.com/fsnotify/fsnotify v1.7.0 // indirect
-	github.com/fzipp/gocyclo v0.6.0 // indirect
-	github.com/ghostiam/protogetter v0.3.6 // indirect
-	github.com/go-critic/go-critic v0.11.4 // indirect
-	github.com/go-toolsmith/astcast v1.1.0 // indirect
-	github.com/go-toolsmith/astcopy v1.1.0 // indirect
-	github.com/go-toolsmith/astequal v1.2.0 // indirect
-	github.com/go-toolsmith/astfmt v1.1.0 // indirect
-	github.com/go-toolsmith/astp v1.1.0 // indirect
-	github.com/go-toolsmith/strparse v1.1.0 // indirect
-	github.com/go-toolsmith/typep v1.1.0 // indirect
-	github.com/go-viper/mapstructure/v2 v2.1.0 // indirect
-	github.com/go-xmlfmt/xmlfmt v1.1.2 // indirect
-	github.com/gobwas/glob v0.2.3 // indirect
-	github.com/gofrs/flock v0.12.1 // indirect
-	github.com/golang/protobuf v1.5.3 // indirect
-	github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a // indirect
-	github.com/golangci/gofmt v0.0.0-20240816233607-d8596aa466a9 // indirect
-	github.com/golangci/misspell v0.6.0 // indirect
-	github.com/golangci/modinfo v0.3.4 // indirect
-	github.com/golangci/plugin-module-register v0.1.1 // indirect
-	github.com/golangci/revgrep v0.5.3 // indirect
-	github.com/golangci/unconvert v0.0.0-20240309020433-c5143eacb3ed // indirect
-	github.com/google/go-cmp v0.6.0 // indirect
+	github.com/fatih/color v1.18.0 // indirect
+	github.com/fsnotify/fsnotify v1.9.0 // indirect
+	github.com/google/go-cmp v0.7.0 // indirect
 	github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect
-	github.com/gordonklaus/ineffassign v0.1.0 // indirect
-	github.com/gostaticanalysis/analysisutil v0.7.1 // indirect
-	github.com/gostaticanalysis/comment v1.4.2 // indirect
-	github.com/gostaticanalysis/forcetypeassert v0.1.0 // indirect
-	github.com/gostaticanalysis/nilerr v0.1.1 // indirect
-	github.com/hashicorp/go-version v1.7.0 // indirect
-	github.com/hashicorp/hcl v1.0.0 // indirect
-	github.com/hexops/gotextdiff v1.0.3 // indirect
-	github.com/inconshreveable/mousetrap v1.1.0 // indirect
-	github.com/jgautheron/goconst v1.7.1 // indirect
-	github.com/jingyugao/rowserrcheck v1.1.1 // indirect
-	github.com/jirfag/go-printf-func-name v0.0.0-20200119135958-7558a9eaa5af // indirect
-	github.com/jjti/go-spancheck v0.6.2 // indirect
-	github.com/julz/importas v0.1.0 // indirect
-	github.com/karamaru-alpha/copyloopvar v1.1.0 // indirect
-	github.com/kisielk/errcheck v1.7.0 // indirect
-	github.com/kkHAIKE/contextcheck v1.1.5 // indirect
-	github.com/kulti/thelper v0.6.3 // indirect
-	github.com/kunwardeep/paralleltest v1.0.10 // indirect
-	github.com/kyoh86/exportloopref v0.1.11 // indirect
-	github.com/lasiar/canonicalheader v1.1.1 // indirect
-	github.com/ldez/gomoddirectives v0.2.4 // indirect
-	github.com/ldez/tagliatelle v0.5.0 // indirect
-	github.com/leonklingele/grouper v1.1.2 // indirect
-	github.com/lufeee/execinquery v1.2.1 // indirect
-	github.com/macabu/inamedparam v0.1.3 // indirect
-	github.com/magiconair/properties v1.8.6 // indirect
-	github.com/maratori/testableexamples v1.0.0 // indirect
-	github.com/maratori/testpackage v1.1.1 // indirect
-	github.com/matoous/godox v0.0.0-20230222163458-006bad1f9d26 // indirect
-	github.com/mattn/go-colorable v0.1.13 // indirect
+	github.com/mattn/go-colorable v0.1.14 // indirect
 	github.com/mattn/go-isatty v0.0.20 // indirect
-	github.com/mattn/go-runewidth v0.0.9 // indirect
-	github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect
-	github.com/mgechev/revive v1.3.9 // indirect
-	github.com/mitchellh/go-homedir v1.1.0 // indirect
-	github.com/mitchellh/mapstructure v1.5.0 // indirect
-	github.com/moricho/tparallel v0.3.2 // indirect
-	github.com/nakabonne/nestif v0.3.1 // indirect
-	github.com/nishanths/exhaustive v0.12.0 // indirect
-	github.com/nishanths/predeclared v0.2.2 // indirect
-	github.com/nunnatsa/ginkgolinter v0.16.2 // indirect
-	github.com/olekukonko/tablewriter v0.0.5 // indirect
-	github.com/pelletier/go-toml v1.9.5 // indirect
-	github.com/pelletier/go-toml/v2 v2.2.3 // indirect
-	github.com/pmezard/go-difflib v1.0.0 // indirect
-	github.com/polyfloyd/go-errorlint v1.6.0 // indirect
-	github.com/prometheus/client_golang v1.12.1 // indirect
-	github.com/prometheus/client_model v0.2.0 // indirect
-	github.com/prometheus/common v0.32.1 // indirect
-	github.com/prometheus/procfs v0.7.3 // indirect
-	github.com/quasilyte/go-ruleguard v0.4.3-0.20240823090925-0fe6f58b47b1 // indirect
-	github.com/quasilyte/go-ruleguard/dsl v0.3.22 // indirect
-	github.com/quasilyte/gogrep v0.5.0 // indirect
-	github.com/quasilyte/regex/syntax v0.0.0-20210819130434-b3f0c404a727 // indirect
-	github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 // indirect
-	github.com/ryancurrah/gomodguard v1.3.5 // indirect
-	github.com/ryanrolds/sqlclosecheck v0.5.1 // indirect
-	github.com/sanposhiho/wastedassign/v2 v2.0.7 // indirect
-	github.com/santhosh-tekuri/jsonschema/v5 v5.3.1 // indirect
-	github.com/sashamelentyev/interfacebloat v1.1.0 // indirect
-	github.com/sashamelentyev/usestdlibvars v1.27.0 // indirect
-	github.com/securego/gosec/v2 v2.21.2 // indirect
-	github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c // indirect
-	github.com/sirupsen/logrus v1.9.3 // indirect
-	github.com/sivchari/containedctx v1.0.3 // indirect
-	github.com/sivchari/tenv v1.10.0 // indirect
-	github.com/sonatard/noctx v0.0.2 // indirect
-	github.com/sourcegraph/go-diff v0.7.0 // indirect
-	github.com/spf13/afero v1.11.0 // indirect
-	github.com/spf13/cast v1.5.0 // indirect
-	github.com/spf13/cobra v1.8.1 // indirect
-	github.com/spf13/jwalterweatherman v1.1.0 // indirect
-	github.com/spf13/pflag v1.0.5 // indirect
-	github.com/spf13/viper v1.12.0 // indirect
-	github.com/ssgreg/nlreturn/v2 v2.2.1 // indirect
-	github.com/stbenjam/no-sprintf-host-port v0.1.1 // indirect
-	github.com/stretchr/objx v0.5.2 // indirect
-	github.com/stretchr/testify v1.9.0 // indirect
-	github.com/subosito/gotenv v1.4.1 // indirect
-	github.com/tdakkota/asciicheck v0.2.0 // indirect
-	github.com/tetafro/godot v1.4.17 // indirect
-	github.com/timakin/bodyclose v0.0.0-20230421092635-574207250966 // indirect
-	github.com/timonwong/loggercheck v0.9.4 // indirect
-	github.com/tomarrell/wrapcheck/v2 v2.9.0 // indirect
-	github.com/tommy-muehle/go-mnd/v2 v2.5.1 // indirect
-	github.com/ultraware/funlen v0.1.0 // indirect
-	github.com/ultraware/whitespace v0.1.1 // indirect
-	github.com/uudashr/gocognit v1.1.3 // indirect
-	github.com/xen0n/gosmopolitan v1.2.2 // indirect
-	github.com/yagipy/maintidx v1.0.0 // indirect
-	github.com/yeya24/promlinter v0.3.0 // indirect
-	github.com/ykadowak/zerologlint v0.1.5 // indirect
-	gitlab.com/bosi/decorder v0.4.2 // indirect
-	go-simpler.org/musttag v0.12.2 // indirect
-	go-simpler.org/sloglint v0.7.2 // indirect
-	go.uber.org/atomic v1.7.0 // indirect
-	go.uber.org/automaxprocs v1.5.3 // indirect
-	go.uber.org/multierr v1.6.0 // indirect
-	go.uber.org/zap v1.24.0 // indirect
-	golang.org/x/exp v0.0.0-20240904232852-e7e105dedf7e // indirect
-	golang.org/x/exp/typeparams v0.0.0-20240314144324-c7f7c6466f7f // indirect
-	golang.org/x/mod v0.21.0 // indirect
-	golang.org/x/sync v0.8.0 // indirect
-	golang.org/x/sys v0.25.0 // indirect
-	golang.org/x/term v0.18.0 // indirect
-	golang.org/x/text v0.18.0 // indirect
-	golang.org/x/tools v0.24.0 // indirect
-	google.golang.org/protobuf v1.34.2 // indirect
-	gopkg.in/ini.v1 v1.67.0 // indirect
-	gopkg.in/yaml.v2 v2.4.0 // indirect
-	gopkg.in/yaml.v3 v3.0.1 // indirect
-	honnef.co/go/tools v0.5.1 // indirect
-	mvdan.cc/unparam v0.0.0-20240528143540-8a5130ca722f // indirect
+	golang.org/x/mod v0.24.0 // indirect
+	golang.org/x/sync v0.13.0 // indirect
+	golang.org/x/sys v0.32.0 // indirect
+	golang.org/x/term v0.31.0 // indirect
+	golang.org/x/text v0.24.0 // indirect
+	golang.org/x/tools v0.31.0 // indirect
 )
--- a/tools/go.sum
+++ b/tools/go.sum
--- a/tools/tools.go
+++ b/tools/tools.go
@ -3,7 +3,6 @@
 package tools

 import (
-	_ "github.com/golangci/golangci-lint/cmd/golangci-lint"
 	_ "gotest.tools/gotestsum"
 	_ "mvdan.cc/gofumpt"
 )