From 82b334b3d33a905e7fc01318386d184669e31d21 Mon Sep 17 00:00:00 2001 From: Knut Ahlers Date: Tue, 9 Mar 2021 23:25:57 +0100 Subject: [PATCH] Fix: Do not panic on weird env list entries Signed-off-by: Knut Ahlers --- env/env.go | 4 ++++ env/env_test.go | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/env/env.go b/env/env.go index 14c9958..15a5562 100644 --- a/env/env.go +++ b/env/env.go @@ -11,6 +11,10 @@ func ListToMap(list []string) map[string]string { } parts := strings.SplitN(entry, "=", 2) + if len(parts) == 1 { + // No value, set to empty string + parts = append(parts, "") + } out[parts[0]] = strings.Trim(parts[1], "\"") } return out diff --git a/env/env_test.go b/env/env_test.go index 7eb5827..611495f 100644 --- a/env/env_test.go +++ b/env/env_test.go @@ -10,19 +10,20 @@ import ( ) var _ = Describe("Env", func() { - Context("ListToMap", func() { var ( list = []string{ "FIRST_KEY=firstvalue", "SECOND_KEY=secondvalue", "WEIRD=", + "NOVALUE", "", } emap = map[string]string{ "FIRST_KEY": "firstvalue", "SECOND_KEY": "secondvalue", "WEIRD": "", + "NOVALUE": "", } ) @@ -51,5 +52,4 @@ var _ = Describe("Env", func() { Expect(l).To(Equal(list)) }) }) - })