.github/workflows/test-and-build.yml

@@ -17,7 +17,7 @@ jobs:
         shell: bash
 
     container:
-      image: luzifer/gh-arch-env
+      image: luzifer/archlinux
       env:
         CGO_ENABLED: 0
         GOPATH: /go
@@ -25,9 +25,28 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
-        with:
-          show-progress: false
+      - name: Enable custom AUR package repo
+        run: echo -e "[luzifer]\nSigLevel = Never\nServer = https://archrepo.hub.luzifer.io/\$arch" >>/etc/pacman.conf
+
+      - name: Install required packages
+        run: |
+          pacman -Syy --noconfirm \
+            awk \
+            curl \
+            diffutils \
+            git \
+            go \
+            golangci-lint-bin \
+            make \
+            nodejs-lts-hydrogen \
+            npm \
+            tar \
+            trivy \
+            unzip \
+            which \
+            zip
+
+      - uses: actions/checkout@v3
 
       - name: Marking workdir safe
         run: git config --global --add safe.directory /__w/elb-instance-status/elb-instance-status
@@ -39,6 +58,11 @@ jobs:
 
       - name: Build release
         run: make publish
+        env:
+          FORCE_SKIP_UPLOAD: 'true'
+          MOD_MODE: readonly
+          NO_TESTS: 'true'
+          PACKAGES: '.'
 
       - name: Extract changelog
         run: 'awk "/^#/ && ++c==2{exit}; /^#/f" "History.md" | tail -n +2 >release_changelog.md'

History.md

@@ -1,7 +1,3 @@
-# 1.1.3 / 2024-04-28
-
-  * Fix memory leak as of unclosed loggers
-
 # 1.1.2 / 2024-04-20
 
   * Fix: Cleanup context after checks have run

checks.go

@@ -39,22 +39,12 @@ func executeAndRegisterCheck(ctx context.Context, checkID string) {
 	var (
 		check  = checks[checkID]
 		logger = logrus.WithField("check_id", checkID)
-		stderr = logger.WithField("stream", "STDERR").Writer()
-		stdout = logger.WithField("stream", "STDOUT").Writer()
 	)
 
-	defer func() {
-		for _, c := range []io.Closer{stderr, stdout} {
-			if err := c.Close(); err != nil {
-				logrus.WithError(err).Error("closing check log-writer (leaked mem)")
-			}
-		}
-	}()
-
 	cmd := exec.Command("/bin/bash", "-e", "-o", "pipefail", "-c", check.Command) //#nosec G204 // Intended to run an user-defined command
-	cmd.Stderr = stderr
+	cmd.Stderr = logger.WithField("stream", "STDERR").Writer()
 	if cfg.Verbose {
-		cmd.Stdout = stdout
+		cmd.Stdout = logger.WithField("stream", "STDOUT").Writer()
 	}
 	err := cmd.Start()