mirror of
https://github.com/Luzifer/elb-instance-status.git
synced 2024-12-23 03:11:20 +00:00
Fix: Cleanup context after checks have run
in order not to leak context resources Signed-off-by: Knut Ahlers <knut@ahlers.me>
This commit is contained in:
parent
879faa0a36
commit
99391db514
1 changed files with 16 additions and 2 deletions
18
checks.go
18
checks.go
|
@ -8,6 +8,7 @@ import (
|
|||
"net/url"
|
||||
"os"
|
||||
"os/exec"
|
||||
"sync"
|
||||
"time"
|
||||
|
||||
"github.com/sirupsen/logrus"
|
||||
|
@ -143,9 +144,22 @@ func loadChecks() error {
|
|||
}
|
||||
|
||||
func spawnChecks() {
|
||||
ctx, _ := context.WithTimeout(context.Background(), cfg.CheckInterval-time.Second)
|
||||
var wg sync.WaitGroup
|
||||
|
||||
ctx, cancel := context.WithTimeout(context.Background(), cfg.CheckInterval-time.Second)
|
||||
|
||||
wg.Add(len(checks))
|
||||
go func() {
|
||||
// Do not block the execution function but cleanup the context after
|
||||
// all checks are done (or cancelled)
|
||||
wg.Wait()
|
||||
cancel()
|
||||
}()
|
||||
|
||||
for id := range checks {
|
||||
go executeAndRegisterCheck(ctx, id)
|
||||
go func(ctx context.Context, id string) {
|
||||
defer wg.Done()
|
||||
executeAndRegisterCheck(ctx, id)
|
||||
}(ctx, id)
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue