Update golangci linter config

Signed-off-by: Knut Ahlers <knut@ahlers.me>
This commit is contained in:
Knut Ahlers 2019-11-13 15:36:28 +01:00
parent 78f33e4a59
commit ad0be881fd
Signed by: luzifer
GPG Key ID: DC2729FDD34BE99E

View File

@ -11,21 +11,43 @@ output:
format: tab format: tab
linters-settings: linters-settings:
funlen:
lines: 100
statements: 60
gocyclo: gocyclo:
# minimal code complexity to report, 30 by default (but we recommend 10-20) # minimal code complexity to report, 30 by default (but we recommend 10-20)
min-complexity: 15 min-complexity: 15
linters: linters:
enable-all: true disable-all: true
disable: enable:
- dupl # Generally a good thing, just too picky - bodyclose # checks whether HTTP response body is closed successfully [fast: true, auto-fix: false]
- errcheck # Covered by GAS in a better way so don't bother me - deadcode # Finds unused code [fast: true, auto-fix: false]
- gochecknoglobals # I object this one: Globals are not always a bad thing - depguard # Go linter that checks if package imports are in a list of acceptable packages [fast: true, auto-fix: false]
- gochecknoinits # I also object this one: Sometimes init functions make sense - dogsled # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f()) [fast: true, auto-fix: false]
- interfacer # Too eager: I don't always pass interfaces but sometimes specific types - funlen # Tool for detection of long functions [fast: true, auto-fix: false]
- lll # GTFO my lawn. - gocognit # Computes and checks the cognitive complexity of functions [fast: true, auto-fix: false]
- unparam # This one complains about parameters expected for interface implementations - goconst # Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
- maligned # I sort structs my way. - gocritic # The most opinionated Go source code linter [fast: true, auto-fix: false]
- whitespace # When I use newlines for better overview STFU - gocyclo # Computes and checks the cyclomatic complexity of functions [fast: true, auto-fix: false]
- godox # Tool for detection of FIXME, TODO and other comment keywords [fast: true, auto-fix: false]
- gofmt # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification [fast: true, auto-fix: true]
- goimports # Goimports does everything that gofmt does. Additionally it checks unused imports [fast: true, auto-fix: true]
- golint # Golint differs from gofmt. Gofmt reformats Go source code, whereas golint prints out style mistakes [fast: true, auto-fix: false]
- gosec # Inspects source code for security problems [fast: true, auto-fix: false]
- gosimple # Linter for Go source code that specializes in simplifying a code [fast: true, auto-fix: false]
- govet # Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: true, auto-fix: false]
- ineffassign # Detects when assignments to existing variables are not used [fast: true, auto-fix: false]
- misspell # Finds commonly misspelled English words in comments [fast: true, auto-fix: true]
- nakedret # Finds naked returns in functions greater than a specified function length [fast: true, auto-fix: false]
- scopelint # Scopelint checks for unpinned variables in go programs [fast: true, auto-fix: false]
- staticcheck # Staticcheck is a go vet on steroids, applying a ton of static analysis checks [fast: true, auto-fix: false]
- structcheck # Finds unused struct fields [fast: true, auto-fix: false]
- stylecheck # Stylecheck is a replacement for golint [fast: true, auto-fix: false]
- typecheck # Like the front-end of a Go compiler, parses and type-checks Go code [fast: true, auto-fix: false]
- unconvert # Remove unnecessary type conversions [fast: true, auto-fix: false]
- unused # Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false]
- varcheck # Finds unused global variables and constants [fast: true, auto-fix: false]
... ...